Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BP: v7 <- #922] Add create client options #962

Closed
wants to merge 1 commit into from
Closed

[BP: v7 <- #922] Add create client options #962

wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 2, 2024

This is an automatic backport of pull request #922 done by Mergify.
Cherry-pick of 401a813 has failed:

On branch mergify/bp/v7/pr-922
Your branch is up to date with 'origin/v7'.

You are currently cherry-picking commit 401a813.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   ibc/relayer.go
	modified:   ibc/relayer_test.go
	modified:   relayer/hermes/hermes_relayer.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   relayer/rly/cosmos_relayer.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@boojamya @mergify
Add create client options (#922)
292af00 
* add create client options

* hermes

* remove comment

* fix comment

(cherry picked from commit 401a813)

# Conflicts:
#	relayer/rly/cosmos_relayer.go
@mergify mergify bot requested a review from a team as a code owner February 2, 2024 16:21
@mergify mergify bot requested a review from jtieri February 2, 2024 16:21
@mergify mergify bot added the conflicts label Feb 2, 2024
@vercel Vercel
Copy link

vercel bot commented Feb 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
interchaintest-docs ❌ Failed (Inspect) Feb 2, 2024 4:22pm

@boojamya
Copy link
Contributor

boojamya commented Feb 2, 2024

createClient needs to be wired up.

See: #965

@boojamya
Copy link
Contributor

These commits were cherry picked into #969.
It was easier to do all this in one PR.
Closing

@boojamya boojamya closed this Feb 20, 2024
@mergify mergify bot deleted the mergify/bp/v7/pr-922 branch February 20, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtieri jtieri Awaiting requested review from jtieri jtieri is a code owner automatically assigned from strangelove-ventures/interchaintest-maintainers

Assignees

@boojamya boojamya

Labels
automerge backported conflicts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@boojamya